Skip to content

Fix Premium Maximum Connected Accounts number in Premium Preview Box #24608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Sventra
Copy link

@Sventra Sventra commented Jun 15, 2022

With one account connected

Before the edit:
image
After the edit:
image

This puts the message and limit on par with Android and iOS limits

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

@john-preston
Copy link
Member

@Sventra I want the max limit to be 6, not 4.

The correct fix would be to replace QString::number(now + 1) + QChar('+') with QString::number(std::max(now, kMaxAccounts) + 1) + QChar('+').

@Sventra
Copy link
Author

Sventra commented Jun 17, 2022 via email

@john-preston
Copy link
Member

@Sventra because it doesn't work that way. You don't buy a premium and get 6 accounts instead of 3. You have 3 "free slots" of accounts, so you buy a premium and get one slot free and can use 4 accounts. Then you can buy another premium (on one of three non-premium accounts) and you can use 5 accounts now, 2 of them premium. And finally 6 accounts if 3 are premium subscribers.

On mobiles it is 4, because through the App Store / Play Market payment / subscription system you can buy only one subscription for your app (so make only one account premium and free only one "slot").

Sorry, something went wrong.

@Sventra
Copy link
Author

Sventra commented Jun 17, 2022 via email

Sorry, something went wrong.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants